-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Google Sheets: handle config errors #26097
Source Google Sheets: handle config errors #26097
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
/test connector=connectors/source-google-sheets
Build FailedTest summary info:
|
/test connector=connectors/source-google-sheets
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Need add unit tests.
status=Status.FAILED, message=f"Unable to connect with the provided credentials to spreadsheet. Error: {reason}" | ||
) | ||
message += "The spreadsheet link is not valid. Enter the URL of the Google spreadsheet you want to sync." | ||
raise AirbyteTracedException( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests added
/test connector=connectors/source-google-sheets
Build PassedTest summary info:
|
/publish connector=connectors/source-google-sheets
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…rs-25691 # Conflicts: # airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json # airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml # airbyte-config-oss/init-oss/src/main/resources/seed/source_specs.yaml
* Source Google Sheets: handle config errors * Source Google Sheets: update docs * Source Google Sheets: fix test * Source Google Sheets: add unit tests * auto-bump connector version * Automated Change --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: artem1205 <artem1205@users.noreply.github.com>
What
Resolve #25691
How
change error message and type to
config_error
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.